-
Notifications
You must be signed in to change notification settings - Fork 906
feat(exasol): add to_date and refactored to_char functions with respect to time mapping #5379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
georgesittas
merged 3 commits into
tobymao:main
from
gpicode:add-to_date-function-to-exasol-dialect
Jul 15, 2025
Merged
feat(exasol): add to_date and refactored to_char functions with respect to time mapping #5379
georgesittas
merged 3 commits into
tobymao:main
from
gpicode:add-to_date-function-to-exasol-dialect
Jul 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct to time mapping.
VaggelisD
reviewed
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nnamdi16, thank you for the contribution, left a few comments:
geooo109
reviewed
Jul 8, 2025
…arser implementation and refactored test
georgesittas
reviewed
Jul 9, 2025
geooo109
approved these changes
Jul 14, 2025
georgesittas
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves adding TO_DATE built -in function to exasol dialect in sqlglot and implementing time mappings