Fix multipleOf
bugs in Number type
#113
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the multipleOf validation crashing when trying to use the modulo operator on a value that is zero, and an InvalidArgumentException when calling multipleOf() with
null
to reset it.Edit: To clarify,
0
is considered to be a multiple of anymultipleOf
value by JSON schema, see for example https://www.jsonschemavalidator.net/s/lPabCUQd. This is also confirmed on https://www.learnjsonschema.com/2020-12/validation/multipleof/ (See examples: "Valid - 0 is a multiple of 4.1")