Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSPO Book] Update 02-chapter.md #398

Closed
wants to merge 1 commit into from
Closed

Conversation

shillasaebi
Copy link
Contributor

Made changes to chapter 2
Copy/editing throughout the chapter
Removed commas, added where necessary
Removed fragments
Rephrased for clarity
Changed capitalizations to match styles throughout chapter

Made changes to chapter 2
Copy/editing throughout the chapter
Removed commas, added where necessary
Removed fragments
Rephrased for clarity 
Changed capitalizations to match styles throughout chapter

Signed-off-by: Shilla <[email protected]>
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for ospomindmap canceled.

Name Link
🔨 Latest commit 18eaaf6
🔍 Latest deploy log https://app.netlify.com/sites/ospomindmap/deploys/657b3631dfa17f00087b134a

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for ospobook ready!

Name Link
🔨 Latest commit 18eaaf6
🔍 Latest deploy log https://app.netlify.com/sites/ospobook/deploys/657b36319c7b990007c7d84f
😎 Deploy Preview https://deploy-preview-398--ospobook.netlify.app/02-chapter
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@souravcipher souravcipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing.

@souravcipher souravcipher requested a review from anajsana January 2, 2024 14:24
@anajsana
Copy link
Member

anajsana commented Jan 19, 2024

@souravcipher @shillasaebi I'm afraid it might be challenging to merge this PR as it is, since content has changed since this PR was submitted.

I think that the easiest option to unblock this is to submit a new PR to the updated main branch, tag this as a duplicated PR (and close without merge), and merge the new one.

@anajsana anajsana added ospo-book issues related to ospo book project bug Something isn't working duplicate ducplicated task and removed bug Something isn't working labels Feb 3, 2024
@anajsana anajsana changed the title Update 02-chapter.md [OSPO Book] Update 02-chapter.md Feb 5, 2024
@anajsana anajsana closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate ducplicated task ospo-book issues related to ospo book project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants