Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow nesting at the root of the router #3051

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Nov 26, 2024

Motivation

It's confusing, there isn't really any nesting going on.

Solution

Remove support for nesting at the root. merge can fully replace nest("" | "/", ...), fallback_service can fully replace nest_service("" | "/", ...).

Closes #2651.

@jplatte jplatte requested a review from yanns November 26, 2024 18:29
Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use this feature, so I cannot judge if the change is good for the users.
From the code point of view, all is looking good.

@jplatte
Copy link
Member Author

jplatte commented Nov 26, 2024

I'm pretty confident that the suggested replacements are better suited for all use cases.

If not, it's backwards-compatible to revert this.

@jplatte jplatte merged commit 11806fb into main Nov 26, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/disallow-root-nesting branch November 26, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider disallowing root nesting
2 participants