Add tokio_util::io::read_exact_arc to safely read a new uninitialized Arc
#7165
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've rewritten this to no longer require rust 1.82. |
nvzqz
reviewed
Feb 25, 2025
Darksonn
reviewed
Feb 25, 2025
joshtriplett
force-pushed
the
read-exact-arc
branch
2 times, most recently
from
b37f27e to
c0eb519
Compare
…ed `Arc` This encapsulates a common bit of unsafety. This uses some workarounds to avoid requiring MSRV 1.82; once tokio uses MSRV 1.82 it can use simpler functions provided by the standard library.
joshtriplett
force-pushed
the
read-exact-arc
branch
from
c0eb519 to
ed3ab08
Compare
|
Passes CI. 🎉 |
Darksonn
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encapsulates a common bit of unsafety.
Motivation
Inspired by having an otherwise completely safe crate in which this was the
only bit of unsafe code. Reading into an uninitialized
Arcand theninitializing it requires the unsafe
assume_init.#7127