subscriber: enable TestWriter to write to stderr
#3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be useful to have a TestWriter that does not log to stdout but stderr instead. For example, that allows for potentially easier filtering of tracing output (because the remaining output of, say, cargo test goes to stdout) or to mirror behavior of env_logger, which by default logs to stderr. Introduce the TestWriter::with_stderr() constructor to enable such usage. The default is left unchanged.
d-e-s-o
added a commit
to d-e-s-o/test-log
that referenced
this pull request
Jan 5, 2025
env_logger was doing it, tracing wasn't. Make sure that both do it. Requires tokio-rs/tracing#3187
joshka
reviewed
Feb 9, 2025
d-e-s-o
force-pushed
the
topic/test-writer-stderr
branch
from
85c3826 to
00ab32a
Compare
joshka
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM. My comments about whether to pass a writer type was incorrect due to rust-lang/rust#90785. This PR is a reasonable approach to this change to add stderr.
joshka
reviewed
Feb 12, 2025
d-e-s-o
force-pushed
the
topic/test-writer-stderr
branch
from
acb3a40 to
b8dfbe8
Compare
|
Can we please go ahead and merge this change? Or what is still blocking it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to have a
TestWriterthat does not log to stdout but stderr instead. For example, that allows for potentially easier filtering oftracingoutput (because the remaining output of, say,cargo testgoes to stdout) or to mirror behavior ofenv_logger, which by default logs to stderr.Introduce the
TestWriter::with_stderr()constructor to enable such usage. The default is left unchanged.