Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out cards with dates in the title #7

Open
CristianCantoro opened this issue Jan 17, 2022 · 4 comments
Open

Filter out cards with dates in the title #7

CristianCantoro opened this issue Jan 17, 2022 · 4 comments

Comments

@CristianCantoro
Copy link

Minor bug that allows cheating, items with dates in the description 😅

Example:
image

This is the corresponding Wikidata item:
https://www.wikidata.org/wiki/Q27952702

@novalis
Copy link

novalis commented Jan 18, 2022

Another example of this is Raedwald of East Anglia, whose title is "7th-century Anglo-Saxon king" (in case you were thinking \d{4} for your regex).

@CristianCantoro CristianCantoro changed the title Filter out cards with titles Filter out cards with datas in the title Jan 18, 2022
@CristianCantoro CristianCantoro changed the title Filter out cards with datas in the title Filter out cards with dates in the title Jan 18, 2022
@FlorianCassayre
Copy link

+1 for that!

Here is another edge case example (notice the BCE part):

image

@varun-s22
Copy link

I would be more than happy to fix this stuff out, if this is still not fixed

@tom-james-watson
Copy link
Owner

A PR would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants