Allow any number of hearts and stop duplicate cards #105
Conversation
philharper
commented
Dec 20, 2023
philharper
commented
- Updated the creation of the hearts to create the number of hearts based off the lives
- Fixed getRandomItem to stop duplicate cards appearing. Although I'm think this may already be sorted by the tooClose method before? I added this after making some changes in my fork to use local data to create a small Christmas game. I removed the tooClose check as the values were only from 1-100 so much more likely to be very close.
|
Not sure why the checks failed? Looks more like an issue with the build image than the changes. |
| @@ -34,11 +34,14 @@ interface Props { | |||
| export default function Hearts(props: Props) { | |||
| const { lives } = props; | |||
|
|
|||
| const elements: JSX.Element[] = []; | |||
| for (let counter = 1; counter <= lives; counter++) { | |||
There was a problem hiding this comment.
Hello! Thank you for your contribution. I also want to have a flexible number of lives, but it's a bit more complicated than you patch. What you're doing here is to add the same number of component Heart that the player has lives, but this isn't what we want: we want the hearts to still be displayed, but differently when we lost a life:
The actual number of lives is initialized here: https://github.com/tom-james-watson/wikitrivia/blob/master/lib/create-state.ts#L15
But as you spotted, we also need to have the number of <Heart> below dynamic.
So, we have to have the number of lives coming from somewhere. Should it be a const in a config file? Should we ask the users? Or let them select a level? (hard 3 lives, medium 5 lives, easy 8 lives?). What do you want?
