Answer:1 Angular projection challenge #1334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalaforge
reviewed
May 20, 2025
|
|
||
| @Component({ | ||
| selector: 'app-list-item', | ||
| template: ` | ||
| <div class="border-grey-300 flex justify-between border px-2 py-1"> | ||
| {{ name() }} | ||
| <button (click)="delete(id())"> | ||
| <ng-content></ng-content> |
There was a problem hiding this comment.
nitpick: use self-closing tag. it's nicer 😅
tomalaforge
reviewed
May 20, 2025
| this.studentStore.deleteOne(id); | ||
| } | ||
| } | ||
| delete = output<number>(); |
There was a problem hiding this comment.
you don't need to output the id, you can just emit an event and the parent will passs the id to the function
tomalaforge
reviewed
May 20, 2025
| [name]="item.firstName" | ||
| [id]="item.id" | ||
| [type]="type()"></app-list-item> | ||
| <app-list-item [id]="item.id" (delete)="delete.emit($event)"> |
There was a problem hiding this comment.
you could move the app-list-item directly in the parent. but this works
tomalaforge
reviewed
May 20, 2025
| readonly list = input<any[] | null>(null); | ||
| readonly type = input.required<CardType>(); | ||
| readonly cardImgSrc = input.required<string>(); | ||
| readonly nameTemplate = input<TemplateRef<any>>(); |
There was a problem hiding this comment.
why do you use an input, most of the time you should use a contentchild with template
tomalaforge
reviewed
May 20, 2025
|
|
||
| ngOnInit(): void { | ||
| this.http.fetchCities$.subscribe((t) => this.store.addAll(t)); | ||
| } |
There was a problem hiding this comment.
you could try to refactor this using httpRessource or rxRessource to be more declarative
|
great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for challenge submission
Warning:
Alternatively, you can still submit your PR to join the list of answered challenges or to be reviewed by a community member. 🔥