extends logs with extra metadata and query params #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add signed_call_raw, signed_call_raw_with_confirmations
tomusdrw
requested changes
Jun 5, 2023
| @@ -279,7 +279,16 @@ impl<T: Transport> Contract<T> { | |||
| } | |||
|
|
|||
| /// Find events matching the topics. | |||
There was a problem hiding this comment.
The documentation should be updated.
Comment on lines
+123
to
+127
| pub fn from_block(mut self, block: Option<BlockNumber>) -> Self { | ||
| if let Some(block) = block { | ||
| self.filter.block_hash = None; | ||
| self.filter.from_block = Some(block); | ||
| } |
There was a problem hiding this comment.
This method should not be changed, the builder should only take values that are defined, not Options. None case should be handled at the call site.
Comment on lines
+133
to
+137
| pub fn to_block(mut self, block: Option<BlockNumber>) -> Self { | ||
| if let Some(block) = block { | ||
| self.filter.block_hash = None; | ||
| self.filter.to_block = Some(block); | ||
| } |
Comment on lines
+144
to
+149
| pub fn block_hash(mut self, hash: Option<H256>) -> Self { | ||
| if let Some(_block_hash) = hash { | ||
| self.filter.from_block = None; | ||
| self.filter.to_block = None; | ||
| self.filter.block_hash = hash; | ||
| } |
Comment on lines
+285
to
+287
| from_block: Option<BlockNumber>, | ||
| to_block: Option<BlockNumber>, | ||
| block_hash: Option<H256>, |
There was a problem hiding this comment.
Having 7 parameters, and 3 of them being optional is a bit too much. I'd like to propose a helper struct with a builder to amalgamate them.
pub struct BlockRange {
from_block: Option<BlockNumber>,
to_block: Option<BlockNumber>,
block_hash: Option<H256>,
}
impl BlockRange {
// set both `from_block` and `to_block`
pub fn range(from: BlockNumber, to: BlockNumber) -> Self;
// set just `from_block`
pub fn from(BlockNumber) -> Self;
// set just `to_block`
pub fn to(BlockNumber) -> Self;
// set just `block_hash`
pub fn hash(H256) -> Self;
// look for one exact block (set both `from/to` and `hash`).
pub fn exact(BlockNumber, H256) -> Self;
// applies the parameters to given filter
pub (crate) fn apply_to(&self, b: FilterBuilder) -> FilterBuilder;
}
Co-authored-by: Tomasz Drwięga <[email protected]>
Co-authored-by: Tomasz Drwięga <[email protected]>
Co-authored-by: Tomasz Drwięga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue below
#650