-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI-REACT], fix preact by changing rollup options #248
Conversation
Please merge |
For future googlers temp fix is: package.json
patches/@TonConnect+ui-react+2.0.0.patch
run Change |
I just:
rollupOptions: {
external: ['react', 'react-dom', 'react-dom/client', 'react/jsx-runtime', '@tonconnect/ui'],
output: {
globals: {
react: 'React',
'react-dom': 'ReactDOM',
'react-dom/client': 'ReactDOMClient',
'react/jsx-runtime': 'ReactJSXRuntime',
'@tonconnect/ui': 'TON_CONNECT_UI'
}
}
import {
useTonConnectUI,
toUserFriendlyAddress,
useTonWallet,
} from 'lib/ui-react' PS: you may need to change tsconfig: |
Why has this PR been pending for so long? |
@T-Damer firstly thank you for your efforts. But I did as you described and got following errors on the step of
What I do wrong? |
Can someone of owner of this repo provide feedback? What should we do in this situation? Should we continue to use crutches, stop using preact, fork this repo? |
We've just released @tonconnect/[email protected] with preact support via PR #330. This update should resolve the compatibility issues you reported. Please update to the latest version and let us know if you encounter any issues with the update. |
Related issue: #247