Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metrics #35

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Remove metrics #35

merged 2 commits into from
Feb 24, 2021

Conversation

skywhale
Copy link
Member

Tentatively remove metrics from the crate as per #34

@skywhale skywhale changed the title Remove metrics (part 1) Remove metrics Feb 24, 2021
mcginty
mcginty approved these changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@mcginty mcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

bschwind
bschwind approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty satisfying change! We'll get more ergonomic metrics added in somehow later so we can still measure handle() calls and such if we want to.

@skywhale skywhale merged commit 2003259 into main Feb 24, 2021
@skywhale skywhale deleted the remove-metrics-1 branch February 24, 2021 08:03
@strohel
Copy link
Member

strohel commented Feb 24, 2021

Looks good! Technically, System and SystemHandle could be now merged into one, if desired?

@skywhale
Copy link
Member Author

skywhale commented Feb 24, 2021 •
edited
Loading

I'm curious to hear @mcginty's thought on @strohel's comment. To me, even though they happen to share the same data, the distinction of System and SystemHandle still makes sense. SystemHandle is cloned and moved to each actor thread via Context, whereas System remains non-clone-able as the user-facing entry point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcginty mcginty mcginty approved these changes

@bschwind bschwind bschwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skywhale @strohel @mcginty @bschwind