Skip to content

Permit streaming_callback of AsyncHTTPClient to be a coroutine. #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eulersIDcrisis
Copy link

This PR adds the ability for streaming_callback of AsyncHTTPClient to be a coroutine. In addition to the small change, this adds a nominal test to verify that things work as expected, at least as best as the streaming_callback approach can permit.

This PR is intended to address a few separate issues listed below:

@eulersIDcrisis eulersIDcrisis marked this pull request as ready for review March 26, 2025 18:22
@eulersIDcrisis
Copy link
Author

@bdarnell , if it is any consolation, I've run tox which passes for me (including the docs and linter checks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant