Skip to content

Commit

Permalink
Additional tools cleanup (#22)
Browse files Browse the repository at this point in the history
* Remove unused exception

* Move EmptyMovementException to net

* Move EventInstanceInProgressException to scripting

* Move WeddingPackets

* Move WeddingPackets to net.packet
  • Loading branch information
MarloDelatorre authored Aug 25, 2024
1 parent 3e50347 commit 068d4ef
Show file tree
Hide file tree
Showing 20 changed files with 49 additions and 60 deletions.
6 changes: 3 additions & 3 deletions scripts/event/WeddingCathedral.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function stopBlessings(eim) {

function sendWeddingAction(eim, type) {
var chr = eim.getLeader();
const Wedding = Java.type('tools.packets.Wedding');
const Wedding = Java.type('net.packet.Wedding');
if (chr.getGender() == 0) {
chr.getMap().broadcastMessage(Wedding.OnWeddingProgress(type == 2, eim.getIntProperty("groomId"), eim.getIntProperty("brideId"), type + 1));
} else {
Expand All @@ -142,13 +142,13 @@ function hidePriestMsg(eim) {
}

function showStartMsg(eim) {
const Wedding = Java.type('tools.packets.Wedding');
const Wedding = Java.type('net.packet.Wedding');
eim.getMapInstance(entryMap + 10).broadcastMessage(Wedding.OnWeddingProgress(false, 0, 0, 0));
eim.schedule("hidePriestMsg", forceHideMsgTime * 1000);
}

function showBlessMsg(eim) {
const Wedding = Java.type('tools.packets.Wedding');
const Wedding = Java.type('net.packet.Wedding');
eim.getMapInstance(entryMap + 10).broadcastMessage(Wedding.OnWeddingProgress(false, 0, 0, 1));
eim.setIntProperty("guestBlessings", 1);
eim.schedule("hidePriestMsg", forceHideMsgTime * 1000);
Expand Down
6 changes: 3 additions & 3 deletions scripts/event/WeddingChapel.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function stopBlessings(eim) {
function sendWeddingAction(eim, type) {
var chr = eim.getLeader();

const Wedding = Java.type('tools.packets.Wedding');
const Wedding = Java.type('net.packet.Wedding');
if (chr.getGender() == 0) {
chr.getMap().broadcastMessage(Wedding.OnWeddingProgress(type == 2, eim.getIntProperty("groomId"), eim.getIntProperty("brideId"), type + 1));
} else {
Expand All @@ -143,13 +143,13 @@ function hidePriestMsg(eim) {
}

function showStartMsg(eim) {
const Wedding = Java.type('tools.packets.Wedding');
const Wedding = Java.type('net.packet.Wedding');
eim.getMapInstance(entryMap + 10).broadcastMessage(Wedding.OnWeddingProgress(false, 0, 0, 0));
eim.schedule("hidePriestMsg", forceHideMsgTime * 1000);
}

function showBlessMsg(eim) {
const Wedding = Java.type('tools.packets.Wedding');
const Wedding = Java.type('net.packet.Wedding');
eim.getMapInstance(entryMap + 10).broadcastMessage(Wedding.OnWeddingProgress(false, 0, 0, 1));
eim.setIntProperty("guestBlessings", 1);
eim.schedule("hidePriestMsg", forceHideMsgTime * 1000);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/client/Character.java
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
import net.PacketCreator;
import tools.Pair;
import tools.Randomizer;
import tools.packets.WeddingPackets;
import net.packet.WeddingPackets;

import java.awt.*;
import java.lang.ref.WeakReference;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package tools.exceptions;
package net.exceptions;

import net.packet.InPacket;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,22 @@
* and open the template in the editor.
*/

package tools.packets;
package net.packet;

import java.util.ArrayList;
import java.util.List;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import client.Character;
import client.inventory.Item;
import constants.id.ItemId;
import constants.id.MapId;
import net.opcodes.SendOpcode;
import net.packet.OutPacket;
import net.packet.Packet;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import net.PacketCreator;
import net.opcodes.SendOpcode;
import tools.StringUtil;

import java.util.ArrayList;
import java.util.List;

/**
* CField_Wedding, CField_WeddingPhoto, CWeddingMan, OnMarriageResult, and all Wedding/Marriage enum/structs.
*
Expand Down Expand Up @@ -419,4 +418,4 @@ public static Packet onWeddingGiftResult(byte mode, List<String> itemnames, List
}
return p;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import server.movement.LifeMovementFragment;
import server.movement.RelativeLifeMovement;
import server.movement.TeleportMovement;
import tools.exceptions.EmptyMovementException;
import net.exceptions.EmptyMovementException;

import java.awt.*;
import java.util.ArrayList;
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/net/server/channel/handlers/MoveDragonHandler.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
*/
package net.server.channel.handlers;

import java.awt.Point;

import client.Character;
import client.Client;
import net.PacketCreator;
import net.exceptions.EmptyMovementException;
import net.packet.InPacket;
import server.maps.Dragon;
import net.PacketCreator;
import tools.exceptions.EmptyMovementException;

import java.awt.*;


public class MoveDragonHandler extends AbstractMovementPacketHandler {
Expand All @@ -53,4 +53,4 @@ public void handlePacket(InPacket p, Client c) {
}
}
}
}
}
17 changes: 9 additions & 8 deletions src/main/java/net/server/channel/handlers/MoveLifeHandler.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,19 @@
*/
package net.server.channel.handlers;

import java.awt.Point;
import java.util.LinkedList;
import java.util.List;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import client.Character;
import client.Client;
import config.YamlConfig;
import net.PacketCreator;
import net.exceptions.EmptyMovementException;
import net.packet.InPacket;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import server.life.MobSkill;
import server.life.MobSkillFactory;
import server.life.MobSkillId;
Expand All @@ -36,12 +43,6 @@
import server.maps.MapObject;
import server.maps.MapObjectType;
import server.maps.MapleMap;
import net.PacketCreator;
import tools.exceptions.EmptyMovementException;

import java.awt.*;
import java.util.LinkedList;
import java.util.List;

/**
* @author Danny (Leifde)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import net.packet.InPacket;
import server.movement.LifeMovementFragment;
import net.PacketCreator;
import tools.exceptions.EmptyMovementException;
import net.exceptions.EmptyMovementException;

import java.util.List;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
package net.server.channel.handlers;

import client.Client;
import net.packet.InPacket;
import net.PacketCreator;
import tools.exceptions.EmptyMovementException;
import net.exceptions.EmptyMovementException;
import net.packet.InPacket;

public final class MovePlayerHandler extends AbstractMovementPacketHandler {
@Override
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/net/server/channel/handlers/MoveSummonHandler.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
*/
package net.server.channel.handlers;

import java.awt.Point;
import java.util.Collection;

import client.Character;
import client.Client;
import net.PacketCreator;
import net.exceptions.EmptyMovementException;
import net.packet.InPacket;
import server.maps.Summon;
import net.PacketCreator;
import tools.exceptions.EmptyMovementException;

import java.awt.*;
import java.util.Collection;

public final class MoveSummonHandler extends AbstractMovementPacketHandler {
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
import server.life.MobSkill;
import net.PacketCreator;
import tools.Pair;
import tools.packets.WeddingPackets;
import net.packet.WeddingPackets;

import java.sql.Connection;
import java.sql.PreparedStatement;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
import server.ItemInformationProvider;
import net.PacketCreator;
import tools.Pair;
import tools.packets.WeddingPackets;
import net.packet.WeddingPackets;

import java.sql.Connection;
import java.sql.PreparedStatement;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import org.slf4j.LoggerFactory;
import server.Marriage;
import net.PacketCreator;
import tools.packets.WeddingPackets;
import net.packet.WeddingPackets;

import java.util.Collections;
import java.util.List;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import net.packet.InPacket;
import scripting.event.EventInstanceManager;
import net.PacketCreator;
import tools.packets.WeddingPackets;
import net.packet.WeddingPackets;

/**
* @author Ronan
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import net.packet.InPacket;
import scripting.event.EventInstanceManager;
import net.PacketCreator;
import tools.packets.WeddingPackets;
import net.packet.WeddingPackets;

/**
* @author Ronan
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/scripting/event/EventManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
import server.life.Monster;
import server.maps.MapleMap;
import server.quest.Quest;
import tools.exceptions.EventInstanceInProgressException;
import scripting.exceptions.EventInstanceInProgressException;

import javax.script.Invocable;
import javax.script.ScriptException;
Expand Down Expand Up @@ -945,4 +945,4 @@ public void run() {
instantiateQueuedInstance();
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package tools.exceptions;
package scripting.exceptions;


/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/scripting/npc/NPCConversationManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
import server.partyquest.Pyramid;
import server.partyquest.Pyramid.PyramidMode;
import net.PacketCreator;
import tools.packets.WeddingPackets;
import net.packet.WeddingPackets;

import java.awt.*;
import java.sql.SQLException;
Expand Down
11 changes: 0 additions & 11 deletions src/main/java/tools/exceptions/IdTypeNotSupportedException.java

This file was deleted.

0 comments on commit 068d4ef

Please sign in to comment.