Skip to content

Commit

Permalink
Move Database config to purely envvars
Browse files Browse the repository at this point in the history
  • Loading branch information
MarloDelatorre committed Aug 24, 2024
1 parent ee37942 commit 5c9012d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 17 deletions.
6 changes: 0 additions & 6 deletions config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,7 @@ worlds:
why_am_i_recommended: Welcome to Medere!
channels: 3


server:
#Database Configuration
DB_URL: "jdbc:mysql://localhost:3306/ashes"
DB_USER: "root"
INIT_CONNECTION_POOL_TIMEOUT: 90 # Seconds

#Login Configuration
WORLDS: 1 #Initial number of worlds on the server.
WLDLIST_SIZE: 21 #Max possible worlds on the server.
Expand Down
7 changes: 0 additions & 7 deletions src/main/java/config/ServerConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@
import java.util.Map;

public class ServerConfig {

//Database Configuration
public String DB_URL;
public String DB_USER;
public String DB_PASS;
public int INIT_CONNECTION_POOL_TIMEOUT;

//Login Configuration
public int WORLDS;
public int WLDLIST_SIZE;
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/config/YamlConfig.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package config;

import database.DatabaseConfig;
import com.esotericsoftware.yamlbeans.YamlReader;

import java.io.FileNotFoundException;
Expand All @@ -16,6 +17,7 @@ public class YamlConfig {

public List<WorldConfig> worlds;
public ServerConfig server;
public DatabaseConfig database;

private static YamlConfig loadConfig() {
try {
Expand Down
7 changes: 3 additions & 4 deletions src/main/java/database/DatabaseConnection.java
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,11 @@ public static Handle getHandle() {
private static HikariConfig getConfig() {
HikariConfig config = new HikariConfig();

config.setJdbcUrl(YamlConfig.config.server.DB_URL);
config.setUsername(YamlConfig.config.server.DB_USER);
config.setJdbcUrl(System.getenv("DB_URL"));
config.setUsername(System.getenv("DB_USER");
config.setPassword(System.getenv("DB_PASS"));

final int initFailTimeoutSeconds = YamlConfig.config.server.INIT_CONNECTION_POOL_TIMEOUT;
config.setInitializationFailTimeout(SECONDS.toMillis(initFailTimeoutSeconds));
config.setInitializationFailTimeout(SECONDS.toMillis(90));
config.setConnectionTimeout(SECONDS.toMillis(30)); // Hikari default
config.setMaximumPoolSize(10); // Hikari default

Expand Down

0 comments on commit 5c9012d

Please sign in to comment.