Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows sharing state if the request and response types don't have a mechanism for that like
http
s request extensions. It's also slightly more type-safe way than request extensions¹.This could certainly use some more docs, though I'm really not good at writing docs. Maybe just an example would be sufficient?
Also if you want I can add this to
ServiceBuilder
as well. I don't know how well in syncServiceBuilder
andServiceExt
are right now, and personally I would probably use theLayer
directly but definitely neverServiceBuilder
🤷🏼¹ can't accidentally have code adding
Arc<Foo>
as an extension, and some other code that tries to access justFoo
; can still try to access state that's not available (due to the layer being applied in the wrong place / conditionally / not at all)