Adds ability to configure stderr output color #3426
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
reviewed
Oct 28, 2024
ssbarnea
force-pushed
the
feat/stderr-color
branch
from
4e18a4f
to
235ac26
Compare
ssbarnea
force-pushed
the
feat/stderr-color
branch
5 times, most recently
from
799495c
to
1db8f80
Compare
ssbarnea
force-pushed
the
feat/stderr-color
branch
from
1db8f80
to
1316db1
Compare
ssbarnea
force-pushed
the
feat/stderr-color
branch
2 times, most recently
from
891cf18
to
cc8393f
Compare
ssbarnea
force-pushed
the
feat/stderr-color
branch
from
cc8393f
to
94417db
Compare
|
@gaborbernat Can you have another look please? Thanks. |
gaborbernat
requested changes
Nov 23, 2024
| @@ -77,7 +87,7 @@ def test_local_execute_basic_pass( # noqa: PLR0913 | |||
| out_got, err_got = out_err.read_out_err() | |||
| if show: | |||
| assert out_got == out | |||
| expected = (f"{Fore.RED}{err}{Fore.RESET}" if color else err) if err else "" | |||
| expected = f"{Fore.__dict__[stderr_color]}{err}{Fore.RESET}" if color and err else err | |||
There was a problem hiding this comment.
Use getattr instead of this dictionary lookup.
auto-merge was automatically disabled
November 26, 2024 02:09
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will allow users to control the coloring of stderr with tox, including ability to avoiding adding colors to it, while still using colors as many tools are already producing colored output.
Please, make sure you address all the checklists (for details on how see
development documentation)! -->
tox -e fix)docs/changelogfolder