Work around Tox hanging with --installpkg sdist due to orphaned build backend #3530
Conversation
|
Thanks for taking a look at this @gaborbernat! The question remains though what we should do with #3512? Should we leave it open? What would the correct fix be for the case of the builder's root actually being reconfigured to another path, and in which scenario can this happen? |
|
OK, I'll link the newsfragment to this PR, leaving the issue as-is for now. |
There was a problem hiding this comment.
@gaborbernat I need help on the tests.
I tried to transplant my MRE from the issue into the test suite, and it seems to work just fine, however, if I deliberately reintroduce the bug, it still passes. 🤔
I verified that a new backend executor is created in that case, however, that doesn't seem to cause any issues, unlike in the real run.
| """ | ||
| sdist = pkg_with_pdm_backend / "dist" / "skeleton-0.1.1337.tar.gz" | ||
| proj = tox_project({"tox.ini": tox_ini}, base=pkg_with_pdm_backend) | ||
| result = proj.run("--installpkg", str(sdist), "--exit-and-dump-after", "10") |
There was a problem hiding this comment.
This --exit-and-dump-after should be increased to something larger (like 120) once I iron out the tests.
This is an incomplete workaround for #3512 (which "works for me" though for all practical purposes) just to get the ball rolling.
See the discussion on the issue (#3512) for the detailed explanation what this workaround does.
tox -e fix)docs/changelogfolder