Make aws client selectable #16
Conversation
egs33
force-pushed
the
make-aws-client-pluggable
branch
from
c7cc3cd to
fd52ff5
Compare
CHANGELOG.md
Outdated
| @@ -1,6 +1,33 @@ | |||
| # Change Log | |||
|
|
|||
| ## [Unreleased] | |||
| ### Breaking Changes | |||
| * Add required "client" arguments to start-consumer | |||
There was a problem hiding this comment.
Since the 'client' argument already exists, please update the comment to 'Make the client argument mandatory'.
| (aws/client {:api :sqs})) | ||
| given-client? (some? (:client opts)) | ||
| num-workers (or (:num-workers opts) | ||
| ^Consumer [queue-url consume client & [opts]] |
There was a problem hiding this comment.
Is it possible to add an assertion for the client here?
There was a problem hiding this comment.
Other type checks are done within gluttony.record.consumer/new-consumer, but should I do client here?
There was a problem hiding this comment.
I didn't notice that. No action is needed then.
egs33
force-pushed
the
make-aws-client-pluggable
branch
from
cf57eca to
2a3109c
Compare
test/gluttony/core_test.clj
Outdated
|
|
||
| (testing "Gather every data in order" | ||
| ;; Add test data | ||
| (let [uuid (UUID/randomUUID)] |
There was a problem hiding this comment.
NIT you can use clojure.core/random-uuid
test/gluttony/core_test.clj
Outdated
| consume (fn [^Message message respond _] | ||
| (log/infof "start to consume:%s" (.body message)) | ||
| (a/go | ||
| ;(is (instance? gluttony.record.message.SQSMessage message)) |
| @@ -0,0 +1,83 @@ | |||
| (ns gluttony.record.aws-sqs-client | |||
| (:require | |||
| [clojure.core.async :as as] | |||
There was a problem hiding this comment.
NIT In another namespace, clojure.core.async is aliased as a.
We should use same alias name in a project.
test/gluttony/core_test.clj
Outdated
| consume (fn [message respond _] | ||
| (log/infof "start to consume:%s" (:body message)) | ||
| (a/go | ||
| ;(is (instance? gluttony.record.message.SQSMessage message)) |
build.edn
Outdated
There was a problem hiding this comment.
Could you add :licenses ?
https://github.com/liquidz/build.edn/blob/main/doc/format/licenses.adoc
Now clojars requires that pom.xml contains license information.
clojars/clojars-web#874
|
Thank you for reviewing! |
Until now, this library has used aws-api.
This PR make available to use other client libraries using protocol.
This version makes it possible to use the AWS SDK.