feat: frontend containerのビルド時にtraQ-S_UIをダウンロードしてくる #2559
Merged
+10
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pugma
reviewed
Jan 16, 2025
|
Dockerを使わずにローカルでフロントエンドをダウンロードしたいこともあるかなと思って一応残してたんですがMakefileとdevelopment.md見る感じDockerを使わない開発は想定されてなさそうなのでMakefileのターゲットごと消しちゃいますね |
ras0q
force-pushed
the
feat/fetch-frontend-on-docker-build
branch
from
abc9c6f to
c4275f6
Compare
ras0q
force-pushed
the
feat/fetch-frontend-on-docker-build
branch
from
c4275f6 to
60fbf65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make up(docker compose up --build -d)の前にmake update-frontendをし忘れるとフロントエンドが立ち上がらないのでDocker Composeのビルド時に引っ張ってくるようにしました