Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burn-jit at HEAD won't compile with the stable toolchain #2569

Open
crutcher opened this issue Nov 30, 2024 · 1 comment
Open

burn-jit at HEAD won't compile with the stable toolchain #2569

crutcher opened this issue Nov 30, 2024 · 1 comment

Comments

@crutcher
Copy link

crutcher commented Nov 30, 2024

Describe the bug
./run-tests.sh std will fail on stable (1.82.0), because some clipping warnings are in use which are new to 1.83.0.

To Reproduce

  1. Check out main at HEAD
  2. rustup override set stable # 1.82.0
  3. ./run-tests.sh std

See:

   Compiling burn-import v0.16.0 (/home/crutcher/git/burn/burn/crates/burn-import)
error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/conv/conv2d/gemm/homogeneous/base.rs:79:17
   |
79 |         #[allow(clippy::manual_div_ceil)]
   |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`
   |
   = note: `-D unknown-lints` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unknown_lints)]`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d.rs:65:9
   |
65 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d_backward.rs:69:9
   |
69 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`
@AsherJingkongChen
Copy link
Contributor

AsherJingkongChen commented Nov 30, 2024

To resolve, try rustup update stable.

crutcher added a commit to crutcher/burn that referenced this issue Dec 1, 2024
At 1.82.0; burn-jit won't compile:
```
   Compiling burn-import v0.16.0 (/home/crutcher/git/burn/burn/crates/burn-import)
error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/conv/conv2d/gemm/homogeneous/base.rs:79:17
   |
79 |         #[allow(clippy::manual_div_ceil)]
   |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`
   |
   = note: `-D unknown-lints` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unknown_lints)]`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d.rs:65:9
   |
65 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d_backward.rs:69:9
   |
69 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`
```

tracel-ai#2569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants