Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rust-version="1.83.0" for burn-jit, due to clippy. #2571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crutcher
Copy link

@crutcher crutcher commented Dec 1, 2024

At 1.82.0; burn-jit won't compile:

   Compiling burn-import v0.16.0 (/home/crutcher/git/burn/burn/crates/burn-import)
error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/conv/conv2d/gemm/homogeneous/base.rs:79:17
   |
79 |         #[allow(clippy::manual_div_ceil)]
   |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`
   |
   = note: `-D unknown-lints` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unknown_lints)]`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d.rs:65:9
   |
65 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d_backward.rs:69:9
   |
69 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`

#2569

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Provide links to relevant issues and dependent PRs.

Changes

Summarize the problem being addressed and your solution.

Testing

Describe how these changes have been tested.

At 1.82.0; burn-jit won't compile:
```
   Compiling burn-import v0.16.0 (/home/crutcher/git/burn/burn/crates/burn-import)
error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/conv/conv2d/gemm/homogeneous/base.rs:79:17
   |
79 |         #[allow(clippy::manual_div_ceil)]
   |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`
   |
   = note: `-D unknown-lints` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unknown_lints)]`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d.rs:65:9
   |
65 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`

error: unknown lint: `clippy::manual_div_ceil`
  --> crates/burn-jit/src/kernel/pool/adaptive_avg_pool2d_backward.rs:69:9
   |
69 | #[allow(clippy::manual_div_ceil)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_filter`
```

tracel-ai#2569
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strictly a clippy issue, not a compilation issue. burn-jit still builds for rust 1.82 (as seen on the CI since we bumped to 1.83).

Since there is no easy way to detect the version when setting an attribute, I suggest we instead add

#[allow(unknown_lints)] // `manual_div_ceil` only appeared in 1.83

when we set #[allow(clippy::manual_div_ceil)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants