Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes how vectorization is applied during fusion #2833

Merged
merged 14 commits into from
Feb 21, 2025

Conversation

nathanielsimard
Copy link
Member

Instead of limiting vectorization based on the most constraining factor, we read inputs multiple times when they can't match the highest vectorization factor. This way, we use the best vectorization factor for each tensor, no matter if others aren't able to.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 77.44565% with 83 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (96839b9) to head (ecc5c80).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-cubecl-fusion/src/on_write/io.rs 54.87% 74 Missing ⚠️
...es/burn-cubecl-fusion/src/on_write/trace/runner.rs 90.00% 6 Missing ⚠️
...ates/burn-cubecl-fusion/src/matmul/optimization.rs 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2833      +/-   ##
==========================================
+ Coverage   82.21%   82.23%   +0.01%     
==========================================
  Files         853      853              
  Lines      113434   113704     +270     
==========================================
+ Hits        93265    93499     +234     
- Misses      20169    20205      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit d67cade into main Feb 21, 2025
11 checks passed
@nathanielsimard nathanielsimard deleted the feat/vectorization-fusion branch February 21, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants