Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max bar spacing option v5 #1740

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Max bar spacing option v5 #1740

merged 4 commits into from
Nov 22, 2024

Conversation

signatenkov
Copy link
Contributor

Type of PR: enhancement

PR checklist:

@signatenkov signatenkov mentioned this pull request Nov 21, 2024
Closed
3 tasks
This was linked to issues Nov 21, 2024
Supporting of Max Bar Spacing #1279
Closed
Support for limiting min/max zoom/scale level #1312
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
ESM 42.47 KB (-0.08% 🔽)
ESM createChart 36.34 KB (0%)
ESM createChartEx 35.1 KB (0%)
ESM Standalone 43.95 KB (-0.05% 🔽)
Standalone 43.92 KB (+0.03% 🔺)
Plugin: Text Watermark 1.86 KB (0%)
Plugin: Image Watermark 1.68 KB (0%)
Plugin: Series Markers 3.97 KB (0%)
Series: LineSeries 2.54 KB (0%)
Series: BaselineSeries 3.04 KB (0%)
Series: AreaSeries 2.99 KB (0%)
Series: BarSeries 2.14 KB (0%)
Series: CandlestickSeries 2.43 KB (0%)
Series: HistogramSeries 2.18 KB (0%)

SlicedSilver
SlicedSilver requested changes Nov 21, 2024
View reviewed changes
src/model/time-scale.ts Outdated Show resolved Hide resolved
tests/e2e/coverage/test-cases/time-scale/bar-width.js Outdated Show resolved Hide resolved
tests/e2e/graphics/test-cases/time-scale/max-bar-spacing.js Outdated Show resolved Hide resolved
@signatenkov signatenkov merged commit 260d685 into v5-candidate Nov 22, 2024
6 of 8 checks passed
@signatenkov signatenkov deleted the max-bar-spacing-option-v5 branch November 22, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlicedSilver SlicedSilver SlicedSilver requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for limiting min/max zoom/scale level Supporting of Max Bar Spacing
2 participants
@signatenkov @SlicedSilver