Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix point markers out of the view #1768

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

illetid
Copy link
Contributor

@illetid illetid commented Jan 2, 2025

Type of PR: bugfix

PR checklist:

Overview of change:

Copy link

github-actions bot commented Jan 2, 2025

size-limit report 📦

Path Size
ESM 44.77 KB (-0.11% 🔽)
ESM createChart 36.8 KB (0%)
ESM createChartEx 35.48 KB (0%)
ESM createYieldCurveChart 36.99 KB (+0.01% 🔺)
ESM createOptionsChart 35.72 KB (0%)
Standalone-ESM 46.28 KB (+0.11% 🔺)
Standalone 46.2 KB (+0.03% 🔺)
Plugin: Text Watermark 1.87 KB (0%)
Plugin: Image Watermark 1.69 KB (0%)
Plugin: Series Markers 3.98 KB (0%)
Series: LineSeries 2.54 KB (+0.16% 🔺)
Series: BaselineSeries 3.2 KB (+0.5% 🔺)
Series: AreaSeries 3.12 KB (+0.13% 🔺)
Series: BarSeries 2.15 KB (0%)
Series: CandlestickSeries 2.42 KB (0%)
Series: HistogramSeries 2.18 KB (0%)
Plugin: UpDownMarkersPrimitive 2.37 KB (0%)

Copy link
Contributor

@SlicedSilver SlicedSilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Seems that we were always calling fill() (at the bottom of the function) even if the for loop never drew anything. Good catch 👍

@illetid illetid merged commit 2f0d1c2 into v5-candidate Jan 2, 2025
28 of 33 checks passed
@illetid illetid deleted the fix/point-markers-out-of-view branch January 2, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants