Don't trigger table row click events in admin UI on text selection.

trailbaseio · Feb 4, 2025 · ea5f85a · ea5f85a
1 parent 75d9b79
commit ea5f85a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/trailbase-core/js/admin/src/components/FormFields.tsx b/trailbase-core/js/admin/src/components/FormFields.tsx
@@ -441,8 +441,8 @@ export function formFieldBuilder(
     return buildNumberFormField({ label });
   }
 
-  console.warn(
-    `Type: (${type}, ${optional}) not (yet) supported. Falling back to textfields`,
+  console.debug(
+    `Custom FormFields not yet implemented for (${type}, ${optional}). Falling back to textfields`,
   );
   if (optional) {
     return buildOptionalTextFormField({ label, nullPlaceholder });

diff --git a/trailbase-core/js/admin/src/components/Table.tsx b/trailbase-core/js/admin/src/components/Table.tsx
@@ -238,6 +238,12 @@ export function DataTable<TData, TValue>(props: Props<TData, TValue>) {
               <For each={table().getRowModel().rows}>
                 {(row) => {
                   const onClick = () => {
+                    // Don't trigger on text selection.
+                    const selection = window.getSelection();
+                    if (selection?.toString()) {
+                      return;
+                    }
+
                     const handler = props.onRowClick;
                     if (!handler) {
                       return;