Skip to content

Commit

Permalink
Use HINTS instead of PATHS when find_package-ing of a vendored depend…
Browse files Browse the repository at this point in the history
…ency.
  • Loading branch information
Peter Goodman committed Dec 7, 2023
1 parent ee6b59c commit b3b1027
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion vendor/abseil/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(absl CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(absl CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/capnproto/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(CapnProto CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(CapnProto CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/gap/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(gap CONFIG REQUIRED PATHS "${CMAKE_INSTALL_PREFIX}" NO_DEFAULT_PATH)
find_package(gap CONFIG REQUIRED HINTS "${CMAKE_INSTALL_PREFIX}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/gflags/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(gflags CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(gflags CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/glog/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(glog CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(glog CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
4 changes: 2 additions & 2 deletions vendor/llvm-project/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(LLVM CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(LLVM CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
if(MX_ENABLE_VAST)
find_package(MLIR CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(MLIR CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
endif()
find_package(Clang CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/pasta/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(pasta CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(pasta CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/re2/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(re2 CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(re2 CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
4 changes: 2 additions & 2 deletions vendor/reproc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,5 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(reproc CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(reproc++ CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(reproc CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(reproc++ CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/rocksdb/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(RocksDB CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(RocksDB CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/vast/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(VAST CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(VAST CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/xxhash/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(xxHash CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(xxHash CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
2 changes: 1 addition & 1 deletion vendor/zstd/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ execute_process(COMMAND ${CMAKE_COMMAND}
execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install
WORKING_DIRECTORY "${build_dir}")

find_package(zstd CONFIG REQUIRED PATHS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)
find_package(zstd CONFIG REQUIRED HINTS "${MX_VENDOR_INSTALL_DIR}" NO_DEFAULT_PATH)

0 comments on commit b3b1027

Please sign in to comment.