Remove warnings on recent versions of Terraform #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent versions of Terraform the former was deprecated in favor of the latter. Since then the following warnings are issued Warning: Argument is deprecated │ │ with module.lambda-at-edge.aws_s3_bucket_object.artifact, │ on .terraform/modules/lambda-at-edge/main.tf line 44, in resource "aws_s3_bucket_object" "artifact": │ 44: bucket = var.s3_artifact_bucket │ │ Use the aws_s3_object resource instead │ │ (and 5 more similar warnings elsewhere) This commit prevents such warnings
In recent versions of Terraform the attribute last_modified
was made redundant, and issues the following warning:
Warning: Redundant ignore_changes element
│
│ on ../../terraform-aws-lambda-at-edge/main.tf line 54, in resource "aws_lambda_function" "lambda":
│ 54: resource "aws_lambda_function" "lambda" {
│
│ Adding an attribute name to ignore_changes tells Terraform to ignore future changes to the argument in configuration after the object has been
│ created, retaining the value originally configured.
│
│ The attribute last_modified is decided by the provider alone and therefore there can be no configured value to compare with. Including this
│ attribute in ignore_changes has no effect. Remove the attribute from ignore_changes to quiet this warning.
This commit prevents this warning.
with this version the user can choose to omit the s3_artifact_bucket variable, allowing the direct upload of the code to AWS Lambda without first uploading it to S3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Public Changelog
[none]
Security Implications
[none]