forked from trussworks/react-file-viewer
-
Notifications
You must be signed in to change notification settings - Fork 0
I 12947 workaround #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Added eslint bypass during merge, the linter didn't like the manual assignment of |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Reverted 85abde8 with some minor modifications |
This reverts commit a24219f.
traskowskycaci
approved these changes
May 31, 2024
deandreJones
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high hopes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I-12947
Note
This is an indirect revert of efforts contributed during PR #3.
#3 was indirectly reverted due to this repository not being compatible with
pdsjf-dist
versions^4.2.67
, where the fix to a critical vulnerability identified from the mymove repo, for now the best course of action is to implement the workaround to avoid this vulnerability. The issue ticket will have the analysis attached and proposed method forward, however for now it is best to roll-back this repository's releases to an old version,v1.2.1
, and implement the workaround increasing the version tov1.2.2
.v1.2.2
will become the latest release. Every version current afterv1.2.2
is not functional, even though it builds.Changes proposed in this pull request:
pdfjs-dist
library updateTo simulate how it will function against mymove, conduct the following
yarn link
to create a symbolic dependency linkyarn link @transcom/react-file-viewer
, then reinstall viayarn install
How to test
Run
yarn test
inside this branch