Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit github-token input #31

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

Wise-StenRaudmets
Copy link
Contributor

Context

Adds explicit github-token input for the action, so it is no longer necessary to pass it through environment variables. It also defaults to ${{ github.token }} so you most likely don't need to specify it.

Checklist

@Wise-StenRaudmets Wise-StenRaudmets force-pushed the add-explicit-github-token branch from 889bd73 to b269ae1 Compare January 22, 2024 07:15
@Wise-StenRaudmets Wise-StenRaudmets marked this pull request as ready for review January 22, 2024 07:21
@Wise-StenRaudmets Wise-StenRaudmets merged commit 4b1c670 into v2 Jan 22, 2024
2 checks passed
@Wise-StenRaudmets Wise-StenRaudmets deleted the add-explicit-github-token branch January 22, 2024 07:23
Wise-StenRaudmets added a commit that referenced this pull request Jan 30, 2024
* Add nvmrc

* Bump dependencies

* Run on node 20

* AX-809: Add support for monorepos (#28)

* Remove default branch variable

* Remove dynamic bundle size comparisons?

* Prototype supporting monorepos

* Add vitest

* Add tests

* Determine app name more reliably

* Add partial issue update support

* Clean up code

* Adjust comment title

* Build dist

* Update README

* Migrate from yarn to pnpm (#29)

* Migrate to pnpm

* Build dist

* Update README

* Add support for running CI (#30)

* Add CI for checking dist

* Run tests in CI

* Adds explicit github-token input (#31)

* Fix missing title in issues (#32)

* Fix artifact ordering (#33)

* Paginate artifact finding, bump TS target to ES2017 (#34)

* Paginate artifact finding, bump TS target to ES2017

* Ignore expired artifacts

* Use separate comments and issues for bundle size measuring (#35)

* Fix issue titles

* Add option to configure commenting strategy (#37)

* Remove delimiter logic

* Adjust branch protection settings for v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant