Paginate artifact finding, bump TS target to ES2017 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wise-StenRaudmets
added a commit
that referenced
this pull request
Jan 29, 2024
* Paginate artifact finding, bump TS target to ES2017 * Ignore expired artifacts
Wise-StenRaudmets
added a commit
that referenced
this pull request
Jan 30, 2024
* Add nvmrc * Bump dependencies * Run on node 20 * AX-809: Add support for monorepos (#28) * Remove default branch variable * Remove dynamic bundle size comparisons? * Prototype supporting monorepos * Add vitest * Add tests * Determine app name more reliably * Add partial issue update support * Clean up code * Adjust comment title * Build dist * Update README * Migrate from yarn to pnpm (#29) * Migrate to pnpm * Build dist * Update README * Add support for running CI (#30) * Add CI for checking dist * Run tests in CI * Adds explicit github-token input (#31) * Fix missing title in issues (#32) * Fix artifact ordering (#33) * Paginate artifact finding, bump TS target to ES2017 (#34) * Paginate artifact finding, bump TS target to ES2017 * Ignore expired artifacts * Use separate comments and issues for bundle size measuring (#35) * Fix issue titles * Add option to configure commenting strategy (#37) * Remove delimiter logic * Adjust branch protection settings for v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Turns out Octokit has a convenient pagination API.
I also bumped TS target to ES2017 because it seemed wasteful and not very useful to generate polyfills for async/iterator code.
Could there also be an alternative approach of saving the workflow id into the reference bundle sizes issue and fetching that later instead of iterating through workflow run history?
Checklist