Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic bundle size calculations #47

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Apr 22, 2024

Context

Re-add support for dynamic bundle sizes. Most of the code was copied as-is from master.

Please verify that my code actually filters out dynamic bundles inside of node_modules. Our codebase does not have bundles in node_modules, so I have no good way of testing it.

Closes #46

Checklist

@canac canac requested a review from a team as a code owner April 22, 2024 21:03
src/comments.ts Show resolved Hide resolved
src/bundle-size.ts Outdated Show resolved Hide resolved
@canac canac force-pushed the dynamic-imports branch from b391963 to db8bfa0 Compare April 24, 2024 18:49
@canac
Copy link
Contributor Author

canac commented Apr 24, 2024

@Wise-StenRaudmets Thanks for the feedback!

@canac canac requested a review from Wise-StenRaudmets April 24, 2024 18:50
Copy link
Contributor

@Wise-StenRaudmets Wise-StenRaudmets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for contributing.

@Wise-StenRaudmets Wise-StenRaudmets merged commit a1da747 into transferwise:v2 Apr 25, 2024
7 checks passed
@canac canac deleted the dynamic-imports branch April 25, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic bundle sizes
2 participants