Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no routes being reported as significant changes #49

Merged
merged 4 commits into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/bootstrap/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
shell: bash

- name: Setup pnpm
uses: pnpm/action-setup@v2
uses: pnpm/action-setup@v3

- name: Setup node
uses: actions/setup-node@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/check-dist.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
push:
branches:
- main
- v2
pull_request:
workflow_dispatch:

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- main
- v2
pull_request:

defaults:
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ inputs:

Available options:
always: Always comment on PRs, even if it's just to say there are no significant changes.
skip-insignificant: Skip commenting on PRs if there are no signficant changes in page sizes.
skip-insignificant: Skip commenting on PRs if there are no significant changes in page sizes.
required: false
default: 'always'
create-issue:
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -127810,7 +127810,7 @@ function getComparisonMarkdownTable({ referenceBundleSizes, actualBundleSizes, n
// Produce a Markdown table with each page, its size and difference to default branch
const rows = getPageChangeInfo(referenceBundleSizes, actualBundleSizes);
if (rows.length === 0) {
return `${name}: None found.`;
return null;
}
// No diff if reference bundle sizes is empty
if (referenceBundleSizes.length === 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/bundle-size.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function getComparisonMarkdownTable({
// Produce a Markdown table with each page, its size and difference to default branch
const rows = getPageChangeInfo(referenceBundleSizes, actualBundleSizes);
if (rows.length === 0) {
return `${name}: None found.`;
return null;
}

// No diff if reference bundle sizes is empty
Expand Down