Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Make strict hostname checking optional on SSL #178

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

wintersrd
Copy link

Problem

SSL hostname checking is strict by default, but not all connections can be guaranteed to be properly configured. In our integrations, one partner frequently uses misconfigured self-signed certificates which are valid but do not match the database host

Proposed changes

This PR adds an optional argument that would allow disabling strict checking of hostname when using SSL. Default behavior is unchanged

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@wintersrd wintersrd requested a review from a team as a code owner August 27, 2024 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant