-
Notifications
You must be signed in to change notification settings - Fork 67
Add additional binary types #83
base: master
Are you sure you want to change the base?
Conversation
added more binary types
Hi @jlloyd-widen , thanks for the contribution! Can you please add unit and integration tests that cover these new types? thx |
@Samira-El I tried running unit and integrations test (didn't even try adding new ones) and I couldn't get them to pass successfully. The instructions in the readme did not work for me. |
Hey, not sure what you meant by instructions didn't work for you and nosetests didn't run any tests. Please try running again with the same commands as the CI job. |
@Samira-El I've updated my code to incorporate your most recent changes and I've added a few integration tests regarding the blob, and binary types. I also fixed a few of the other data type integration tests that appeared to be failing. let me know what you think. |
This addresses #66
Checklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]
(if applicable. AP-NNNN = JIRA ID)AP-NNN
(if applicable. AP-NNN = JIRA ID)