Fixes https://github.com/transferwise/pipelinewise-tap-postgres/issues/107

[deanmorin]

Problem

If you select new tables to add to an existing log based extract, it'll do a "logical_initial" full table sync on those new tables each and every time the tap runs. It'll never switch over to log based replication for them.

Proposed changes

Modify sync_logical_streams so that it considers "traditional streams" that are actually log based, and saves their bookmarks to the state.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

• Description above provides context of the change
• I have added tests that prove my fix is effective or that my feature works
• Unit tests for changes (not needed for documentation changes)
• CI checks pass with my changes
• Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
• Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
• Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
• Commits follow "How to write a good git commit message"
• Relevant documentation is updated including usage instructions

[deanmorin]

Forced pushed # pylint: disable=too-many-arguments

[judahrand]

@Samira-El What is needed to get these changes merged? I'm happy to put a bit of work into this but would appreciate some direction as to what testing / additional changes are needed from your perspective.

[Samira-El]

@Samira-El What is needed to get these changes merged? I'm happy to put a bit of work into this but would appreciate some direction as to what testing / additional changes are needed from your perspective.

Hey Judah, haven't had the time to check out this PR. Would be great to cover this change with some unit and integrations tests.

[deanmorin]

I'm closing this in favor of #144 which also solves the issue, but in a cleaner way.