This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Refresh streams schema #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A later commit modifies tests/test_streams_utils.py, and I noticed it was the only file really using tabs in this repo. Changed it to spaces, and replaced a few other random ones.
Fixes transferwise#128 - Moves the bulk of the code out of the context manager (open_connection) since it isn't needed. - Creates private functions for merging existing metadata and schema to dicts with those in `new_discovery`. - Aliases `metadata` (from singer) to `metadata_util`. I kept using `metadata` as a local var when developing by accident and breaking things.
Changed from debug -> info level. I deployed the changes from this PR, and I wanted to make sure things were working as expected. It was in an environment with sensitive data, so I wasn't able to simply switch to debug level since that would lead the sensitive data to the logs. Also added the column being affected to the message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My view on #129