[AP-867] Make unit tests to work (#8)

.circleci/config.yml

@@ -12,15 +12,17 @@ jobs:
             python3 -m venv venv
             . venv/bin/activate
             pip install --upgrade pip
-            pip install .[test]
+            pip install .[test] --use-feature=2020-resolver
       - run:
          name: 'Pylinting'
          command: |
            . venv/bin/activate
            pylint tap_slack -d C,W,unexpected-keyword-arg,duplicate-code,too-many-arguments,too-many-locals,too-many-nested-blocks,useless-object-inheritance,no-self-argument,raising-non-exception,no-member
       - run:
           name: 'Unit Tests'
-          command: echo "No unit tests :("
+          command: |
+            . venv/bin/activate
+            pytest tests
 
 workflows:
   version: 2

README.md

@@ -189,47 +189,16 @@ The `Users` stream _does_ store information about when a User record was last up
  - API Documentation: [Link](https://api.slack.com/methods/files.remote.list)
 
 ## Testing the Tap
-
-While developing the Slack tap, the following utilities were run in accordance with Singer.io best practices:
-Pylint to improve [code quality](https://github.com/singer-io/getting-started/blob/master/docs/BEST_PRACTICES.md#code-quality):
-```bash
-> pylint tap_slack -d missing-docstring -d logging-format-interpolation -d too-many-locals -d too-many-arguments
-```
-Pylint test resulted in the following score:
-```bash
-Your code has been rated at 9.72/10 
 
+Install test dependencies
+```bash
+python3 -m venv venv
+. venv/bin/activate
+pip install --upgrade pip
+pip install .[test]
 ```
 
-To [check the tap](https://github.com/singer-io/singer-tools#singer-check-tap) and verify working:
+To run tests:
 ```bash
-> tap-slack --config tap_config.json --catalog catalog.json | singer-check-tap > state.json
-> tail -1 state.json > state.json.tmp && mv state.json.tmp state.json
-```
-Check tap resulted in the following:
- ```bash
-Checking stdin for valid Singer-formatted data
-The output is valid.
-It contained 3657 messages for 9 streams.
-
-    581 schema messages
-   2393 record messages
-    683 state messages
-
-Details by stream:
-+-----------------+---------+---------+
-| stream          | records | schemas |
-+-----------------+---------+---------+
-| threads         | 633     | 573     |
-| user_groups     | 1       | 1       |
-| channel_members | 1049    | 1       |
-| users           | 22      | 1       |
-| channels        | 0       | 1       |
-| remote_files    | 3       | 1       |
-| messages        | 573     | 1       |
-| teams           | 1       | 1       |
-| files           | 111     | 1       |
-+-----------------+---------+---------+
+pytest
 ```
-----
-Copyright © 2019 Stitch

setup.py

@@ -24,8 +24,7 @@
       extras_require={
           'test': [
               'pylint',
-              'ipdb',
-              'nose'
+              'pytest'
           ]
       },
       python_requires='>=3.6',

tests/test_schemas.py

@@ -0,0 +1,23 @@
+import os
+import singer
+import jsonschema
+
+class TestSchemas:
+    """ Test schemas """
+    schemas_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), '..', 'tap_slack', 'schemas'))
+
+    def get_schemas(self):
+        """Function to get all json schema paths"""
+        schemas = []
+        for f in os.listdir(self.schemas_dir):
+            if os.path.isfile(os.path.join(self.schemas_dir, f)):
+                if '.json' in f:
+                    schemas.append(os.path.join(self.schemas_dir, f))
+
+        return schemas
+
+    def test_schemas(self):
+        """Check if every schema is a valid JSON Schema"""
+        for schema in self.get_schemas():
+            s = singer.utils.load_json(schema)
+            assert jsonschema.Draft7Validator(s).check_schema(s) is None