Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Don't set data retention time when creating a table #432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deanmorin
Copy link

@deanmorin deanmorin commented Jun 21, 2024

Workaround for #331

Problem

We have the DATA_RETENTION_TIME_IN_DAYS snowflake parameter set to 90 at the account level. However, when this target creates a table it's hardcoded to 1 day. This was discovered when we tried to use time travel to investigate a data issue and found we couldn't look back far enough.

#331

Proposed changes

Don't modify the data retention time.

This is technically a breaking change since the existing version always sets the retention time to 1 day.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@deanmorin deanmorin marked this pull request as ready for review June 22, 2024 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant