Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase logical_poll_total_seconds for Postgres e2e tests #957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tolsto
Copy link
Contributor

@Tolsto Tolsto commented May 10, 2022

Problem

Postgres sometimes takes some time until it will start
sending the log stream. The current timeout of 3 seconds
would cause 80% of my test runs to fail as the sync would
end before Postgres starts streaming.

Proposed changes

Increase timeout.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Postgres sometimes takes some time until it will start
sending the log stream. The current timeout of 3 seconds
would cause 80% of my test runs to fail as the sync would
end before Postgres starts streaming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant