Added UuidUtils add method. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onukristo
force-pushed
the
add_method
branch
from
342f9c9 to
0ae8be0
Compare
xSeagullx
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
I think a javadoc on the method would be great, along with an intended use and a warning.
If two services decide to "branch out" same way, then their UUID will be equal, removing one of the qualities of UUID (being globally unique).
So we can have issues if that UUID is then used in a globally unique setting (as a trace id) or in the same local context (e.g. two services branch out of single UUID to do an operation on the transfer using that UUID as an idempotency key)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added UuidUtils add method to add a constant to an UUID.
This would easily allow services to branch out UUIDs.
Checklist