-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ThreadLocalAccessor for TwContext #49
Open
hussainkarafallah
wants to merge
6
commits into
master
Choose a base branch
from
context-accessor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−2
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bddb171
hey
hussainkarafallah 498dacb
hey
hussainkarafallah 880a824
Merge branch 'master' into context-accessor
hussainkarafallah 6053fa5
happy-checkstyle
hussainkarafallah 5076dff
switch to autoconfig
hussainkarafallah a1e6ee5
ok
hussainkarafallah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
version=2.0.1 | ||
version=2.1.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
tw-context/src/main/java/com/transferwise/common/context/TwContextThreadLocalAccessor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.transferwise.common.context; | ||
|
||
import static com.transferwise.common.context.UnitOfWork.TW_CONTEXT_KEY; | ||
|
||
import io.micrometer.context.ThreadLocalAccessor; | ||
|
||
public class TwContextThreadLocalAccessor implements ThreadLocalAccessor<TwContext> { | ||
|
||
@Override | ||
public Object key() { | ||
return TW_CONTEXT_KEY; | ||
} | ||
|
||
@Override | ||
public TwContext getValue() { | ||
return TwContext.current(); | ||
} | ||
|
||
@Override | ||
public void setValue(TwContext context) { | ||
context.attach(); | ||
} | ||
|
||
@Override | ||
public void reset() { | ||
TwContext.ROOT_CONTEXT.attach(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably might be better to put this logic into the starter package and using an autoconfiguration mechanism for that. Using the static block is probably too hard coded in this case.