Upgrading libraries, mainly the JSqlParser, to support more queries out of the box. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onukristo
commented
Jan 25, 2024
| import net.sf.jsqlparser.JSQLParserException; | ||
| import net.sf.jsqlparser.parser.CCJSqlParser; | ||
| import net.sf.jsqlparser.parser.StringProvider; | ||
| import net.sf.jsqlparser.statement.Statements; | ||
|
|
||
| public class SqlParser { | ||
|
|
||
| /* |
There was a problem hiding this comment.
New version supports the queries we tried to modify.
| @@ -120,18 +127,26 @@ protected ParsedQuery parseSql(String sql, TwContext context) { | |||
| return new ParsedQuery(); | |||
| } | |||
|
|
|||
| ParsedQuery result = new ParsedQuery(); | |||
| long startTimeMs = System.currentTimeMillis(); | |||
| var result = new ParsedQuery(); | |||
There was a problem hiding this comment.
Personally I don't see how using var here makes it better. long vs var, ParsedQuery vs var. In this case using var hurts the readability more in my opinion.
| } | ||
| } | ||
|
|
||
| for (Statement stmt : stmts) { |
There was a problem hiding this comment.
Line 135:
for (var stmt : stmts) {
Line 141:
for (Statement stmt : stmts) {
var vs proper class name.
tw-peeterkarolin
approved these changes
Jan 26, 2024
|
/wise-bot run-action sync-codeowners |
|
Your CODEOWNERS or the
You have more info in the docs |
|
🟢 sync-codeowners action completed with successful result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgrading libraries, mainly the JSqlParser, to support more queries out of the box.
Checklist