[APPENG-849] Fix prometheus client cant cast metric type gauge to inf…

…o issue (#86)
transferwise · Jul 25, 2024 · 0e34b7d · 0e34b7d
1 parent 0a83267
commit 0e34b7d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.29.1] 2024-07-25
+### Fixed
+- Fixed the prometheus metrics cant cast metric type gauge to info issue.
+
 ## [0.29.0] - 2024-07-16
 
 ### Added

diff --git a/gradle.properties b/gradle.properties
@@ -1 +1 @@
-version=0.29.0
+version=0.29.1
diff --git a/tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java b/tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java
@@ -34,7 +34,9 @@
 @Slf4j
 public class TkmsMetricsTemplate implements ITkmsMetricsTemplate, InitializingBean {
 
-  public static final String GAUGE_LIBRARY_INFO = "tw_library_info";
+  // Miccrometer 1.13 (which comes with Spring boot 3.3) doesn't properly convert gauge metrics with info suffix when using underscore,
+  // using dot here as a workaround
+  public static final String GAUGE_LIBRARY_INFO = "tw.library.info";
   public static final String TIMER_PROXY_POLL = "tw_tkms_proxy_poll";
   public static final String GAUGE_PROXY_POLL_IN_PROGRESS = "tw_tkms_proxy_poll_in_progress";
   public static final String TIMER_PROXY_CYCLE = "tw_tkms_proxy_cycle";