Error message "Topics for default shard have to be specified on 'tw-t…

…kms.topics' property." given, when default shard was not defining any topics. (#83)

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.28.2] - 2024-01-25
+
+### Fixed
+
+- Error message "Topics for default shard have to be specified on 'tw-tkms.topics' property." given, when default shard was not defining any topics.
+
 ## [0.28.1] - 2024-01-12
 
 ### Fixed

gradle.properties

@@ -1 +1 @@
-version=0.28.1
+version=0.28.2

tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/TkmsTopicValidator.java

@@ -92,7 +92,7 @@ public void preValidateAll() {
       var shardProperties = tkmsProperties.getShards().get(shard);
       List<String> shardTopics = shardProperties == null ? null : shardProperties.getTopics();
 
-      if (shardTopics != null && shard == tkmsProperties.getDefaultShard()) {
+      if (shardTopics != null && !shardTopics.isEmpty() && shard == tkmsProperties.getDefaultShard()) {
         throw new IllegalStateException("Topics for default shard have to be specified on 'tw-tkms.topics' property.");
       }
 

tw-tkms-starter/src/test/resources/application.yml

@@ -36,6 +36,9 @@ tw-tkms:
   kafka:
     bootstrap.servers: "${TW_TKMS_KAFKA_1_TCP_HOST:localhost}:${TW_TKMS_KAFKA_1_TCP_9092}"
   shards:
+    # Covers a bug with topics validation
+    0:
+      polling-interval: 6ms
     1:
       polling-interval: 6ms
       kafka: