[APPENG-849] Add spring boot 3.3 support #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gravewalker666
commented
Jul 16, 2024
tw-tkms-starter/build.gradle
Outdated
Comment on lines
58
to
60
| if (!springBootVersion.startsWith("2.6")) { | ||
| testImplementation libraries.flywayMysql | ||
| } |
There was a problem hiding this comment.
@tw-peeterkarolin should we get rid of this block now that we don't support 2.6 anymore?
There was a problem hiding this comment.
I'm not Peeter, but I think that will make sense
There was a problem hiding this comment.
Agree as well that now that we only have Boot 2.7 and up then there is no need for that if block. Now we can always add the flywayMysql
xSeagullx
previously approved these changes
Jul 22, 2024
tw-tkms-starter/build.gradle
Outdated
| @@ -55,9 +55,10 @@ dependencies { | |||
| testImplementation project(":tw-tkms-test-starter") | |||
|
|
|||
| testImplementation libraries.awaitility | |||
| if (!springBootVersion.startsWith("2.6")) { | |||
| testImplementation libraries.flywayMysql | |||
| if (springBootVersion.startsWith("3.3")) { | |||
There was a problem hiding this comment.
That if might be better if we use !springBootVersion.startsWith("3.2") instead so that it will be forward compatible with next Spring Boot versions.
On the other hand it will constantly remind us that we need to double check if we still need that if at all in new boot versions, so it's more an optional comment.
Gravewalker666
force-pushed
the
APPENG-849
branch
from
743640e to
0b9a53c
Compare
xSeagullx
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request attempts to upgrade the library to use spring boot 3.3.
Checklist
Details from ticket: APPENG-849
Update platform libraries matrix tests to run with boot 3.3