[PPP-502] TKMS - Add decorator for message headers #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussainkarafallah
changed the title
| @@ -144,10 +147,10 @@ protected void checkActiveTransaction(int shard, boolean transactionActive, bool | |||
|
|
|||
| @Override | |||
| public SendMessagesResult sendMessages(SendMessagesRequest request) { | |||
| var transactionActive = TransactionSynchronizationManager.isActualTransactionActive(); | |||
There was a problem hiding this comment.
making checkstyle happy
Distance between variable 'transactionActive' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
onukristo
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding a decorator interface that services can write their headers injectors separately
To be used with cases like transfers where we want to add transfer headers in the whole service
So instead of modifying every message, you can write a single decorator
Checklist