Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPENG-927] Yield MetricFilter's as Beans for Spring to apply to MeterRegistry via post processing #88

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

jordanhasgul
Copy link
Member

@jordanhasgul jordanhasgul commented Aug 8, 2024

Context

A PR to micrometer (micrometer-metrics/micrometer#4917) added a log message to warn that MeterFilter's have been applied to MeterRegistry after meters have been registered with it.

This library is an offender. This PR no longer explicitly applied MeterFilter's itself and insteads yields them as Beans for Spring to pass to MeterRegistryPostProcessor which will apply them.

Checklist

Details from ticket: APPENG-927

Stop explicitly applying MeterFilter's in all platform libraries

Context in Slack thread: [https://wise.slack.com/archives/C0437QJBY4V/p1722955739049859|https://wise.slack.com/archives/C0437QJBY4V/p1722955739049859|smart-link]

We should go over our platform libraries and ensure that we don’t explicitly apply MeterFilter’s to MeterRegistry. Instead we should created the MeterFilter’s and expose them to Spring as Bean’s so that {{MeterRegistryPostProcessor}} can apply them correctly for us.

Known offenders are:

  • tw-entrypoints - done
  • tw-service-comms
  • tw-tkms
  • wise-kafka-processor

@jordanhasgul jordanhasgul requested a review from a team as a code owner August 8, 2024 14:24
@jordanhasgul jordanhasgul merged commit 6b08a17 into master Aug 9, 2024
14 checks passed
@jordanhasgul jordanhasgul deleted the APPENG-927 branch August 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants