-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add KafkaProducer post-processor to enable extensions from other libraries #90
Conversation
tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/config/TkmsKafkaProducerProvider.java
Show resolved
Hide resolved
I think it would make sense to play this through with a snapshot version in combination with tw-observability-base to understand how the whole flow will work. |
I plan to look into that. At first I plan to see if I can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the snapshot version is cleaned up + optionally update the date of the changelog
@@ -51,4 +49,9 @@ public List<ITkmsMessageDecorator> messageDecorators() { | |||
return Collections.emptyList(); | |||
} | |||
|
|||
@Bean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably would be better to declare the autowire usage as
@Autowired(required = false)
Then you don't need to explicitly provide an empty list bean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed that.
|
Context
I'd like to enable async traces for messages sent out with
tw-tkms
.To able to use OpenTelemetry's KafkaTelemetry class from the
tw-observability-base
, I'm adding a newKafkaProducer
post-processor interface that can be used fromtw-observability-base
to call theKafkaTelemetry:wrap()
to create the necessary async traces for all message sent out withtw-tkms
.Checklist