Minor fix in transform.py, remove obsolete todo

transferwise · May 7, 2024 · 89175bf · 89175bf
1 parent 56fd3ad
commit 89175bf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/wise_pizza/solve/tree.py b/wise_pizza/solve/tree.py
@@ -165,7 +165,6 @@ def get_best_subtree_result(
 
 
 def build_tree(root: ModelNode, num_leaves: int, max_depth: Optional[int] = 1000):
-    # TODO: modify this to also accept max_depth
     for _ in range(num_leaves - 1):
         best_node = get_best_subtree_result(root, max_depth)
         if best_node.error_improvement > 0:

diff --git a/wise_pizza/transform.py b/wise_pizza/transform.py
@@ -92,7 +92,7 @@ def inverse_transform_mean(self, x: np.ndarray) -> np.ndarray:
                 0.0, np.exp(np.minimum(x, np.log(self.max_inverse))) - self.offset
             )
         else:
-            np.maximum(0.0, np.exp(x) - self.offset)
+            return np.maximum(0.0, np.exp(x) - self.offset)
 
     def transform_weight(self, w: np.ndarray, mean: np.ndarray) -> np.ndarray:
         # pure math would give weight_pow_sc = 1, but then